Remove obsolete l10n strings (Fix #15496) #15770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephaniehobson
added
L10N
Needs Review
wen-2018
approved these changes
Dec 19, 2024
| @@ -29,14 +26,8 @@ firefox-all-down-arrow = Choose from the list below | |||
|
|
|||
| # Used as an accessible label for a help button. The text is replaced with a "?" icon. | |||
| firefox-all-get-help = Get help | |||
| # Obsolete string (expires 2024-10-30) | |||
| firefox-all-browser = Browser: | |||
There was a problem hiding this comment.
issue: This string should be removed in here too: https://github.com/mozilla/bedrock/blob/main/bedrock/firefox/templates/firefox/all/product.html#L10
There was a problem hiding this comment.
Nice catch, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15770 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 160 160
Lines 8359 8360 +1
=======================================
+ Hits 6610 6611 +1
Misses 1749 1749 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
L10n maintenance
Significant changes and points to review
Issue / Bugzilla link
Fix #15496
Testing
Do a
make preflightto make sure you have the most recent translations.http://localhost:8000/fr/firefox/all/
http://localhost:8000/fr/firefox/features/adblocker/
http://localhost:8000/fr/firefox/135.0a1/whatsnew/
http://localhost:8000/fr/newsletter/firefox/
http://localhost:8000/de/firefox/challenge-the-default/
http://localhost:8000/fr/firefox/challenge-the-default/
http://localhost:8000/es-ES/firefox/challenge-the-default/
http://localhost:8000/it/firefox/challenge-the-default/
http://localhost:8000/pl/firefox/challenge-the-default/